Skip to content

Enable copying tables with generated columns #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: REL2_x_STABLE
Choose a base branch
from

Conversation

postsql
Copy link

@postsql postsql commented Apr 3, 2024

Skip generated columns as these are not COPY-able

Currently pglogical is unable to replicate tables with generated columns, this pull request fixes this

Skip generated columns as these are not COPY-able
@postsql postsql changed the title Update pglogical_functions.c Enable coying tables with generated columns Apr 3, 2024
@postsql postsql changed the title Enable coying tables with generated columns Enable copying tables with generated columns Apr 3, 2024
@nmisch nmisch self-assigned this May 23, 2025
@nmisch nmisch self-requested a review May 23, 2025 18:55
@nmisch nmisch removed their assignment May 23, 2025
Copy link
Collaborator

@nmisch nmisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. How feasible is it to add test coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants