Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting based on best practices; #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stkr22
Copy link

@stkr22 stkr22 commented Nov 24, 2023

I adjusted quite a few things, mostly to:

  • quality of life changes like allowing autocreation of admin password or setting URL based on ingress host
  • upgrading dependencies
  • increasing security by using secrets for passwords and enabling security context
  • adding healthchecks

Some changes might be very opinionated/based on my personal experience with Kubernetes.

@300481
Copy link
Owner

300481 commented Dec 30, 2023

Thank you @stkr22 for your PR.
I've updated the Chart in the last days and yes, you're so right, there are some things which need to be changed to get this Chart to a real good condition.

I hope I will have some free time in the next days/weeks to review your PR and hopefully can merge it.

My highest priority the last days was to remove the dependencies of MariaDB Helm Chart and Memcached Helm Chart and, to update Seafile to the current container version 11.0.3
In the past it was not so easy. The version 8 had a bad Nginx config so I had to rebuild it by my own, but from version 9 this problem is solved (the TLS certificate renewal by LetsEncrypt, what I manage with Cert-Manager)
From now on I plan to use the official Images from Haiwen.

@300481
Copy link
Owner

300481 commented Dec 30, 2023

Hi @stkr22, thanks again for the great ideas and your contribution!

As I've changed some things in the Chart, may I ask you to:

  • rebase your branch to my dev branch
  • create some more granular changes and pull requests against my dev branch
    It is easier to check and merge small changes as one big bang change.

Or another idea, because I've seen a lot of forks and other Charts on artifacthub.io, should we create an organization and invite all the folks to work together on a Chart?
I think we are all doing this in our free time and a consolidated repository with a good contribution guide could help us all.

@stkr22
Copy link
Author

stkr22 commented Jan 21, 2024

@300481 not sure about that, to be honest I switched to a commercial seafile provider and stopped self-hosting it for now.

Will have a look when I have time but that might take a while.

@300481
Copy link
Owner

300481 commented Jan 21, 2024

@stkr22 no problem, was just an idea. Hope your provider is good. I'll try to do my best with your contributions, as my time allows it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants