Skip to content

fix: 입고 후 배송 완료#56

Merged
vivivim merged 1 commit intomainfrom
SPM-368
Nov 11, 2025
Merged

fix: 입고 후 배송 완료#56
vivivim merged 1 commit intomainfrom
SPM-368

Conversation

@vivivim
Copy link
Contributor

@vivivim vivivim commented Nov 11, 2025

📝 Summary

🙏 Question & PR point

📬 Reference

Summary by CodeRabbit

  • 버그 수정
    • 배송 도착 시 주문 상태가 올바르게 업데이트되도록 개선했습니다.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Caution

Review failed

The pull request is closed.

요약

InventoryService에 OrderService 의존성을 추가하고, deliveryProcess 메서드에서 주문 상태 이벤트를 OrderStatus.CONFIRMED에서 OrderStatus.ARRIVED로 변경하여 주문 도착 상태를 명확히 반영합니다.

변경 사항

내용 / 파일(들) 변경 요약
OrderService 통합
src/main/java/com/sampoom/backend/api/inventory/service/InventoryService.java
OrderService 및 OrderStatus 임포트 추가, OrderService 필드 주입, deliveryProcess 메서드에서 주문 상태를 ARRIVED로 설정하는 로직 추가

예상 코드 리뷰 난이도

🎯 2 (Simple) | ⏱️ ~10 minutes

  • OrderStatus.ARRIVED가 OrderStatus.CONFIRMED를 대체하는 이유 및 비즈니스 로직 검증 필요
  • OrderService 의존성 주입이 기존 기능에 미치는 영향 확인

관련 PR

제안 레이블

ready-to-merge

제안 검토자

  • Lee-Jong-Jin
  • CHOOSLA
  • yangjiseonn
  • Sangyoon98
  • taemin3

축하 시

🐰 주문이 도착했네요, 상태도 명확하게!
OrderService와 손을 잡고,
ARRIVED 상태로 반짝반짝✨
재고 관리는 이제 더욱 완벽하네요!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch SPM-368

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cd48a9 and 5b2c2cb.

📒 Files selected for processing (1)
  • src/main/java/com/sampoom/backend/api/inventory/service/InventoryService.java (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@taemin3 taemin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

Copy link
Member

@CHOOSLA CHOOSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인

@vivivim vivivim merged commit be19212 into main Nov 11, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants