Skip to content

Conversation

@khimabaja
Copy link
Collaborator

No description provided.

@3C-SCSU
Copy link
Owner

3C-SCSU commented Nov 25, 2025

Code approval process -- 3 Steps review:
(1) Yes; (2) Maybe; (3) No; > {Number of files, and total lines changed:add/delete lines} [Reasoning]
example - feedback >> (2) > {4: +153/-20} [ Code needs to explain what it does ]

Copy link
Owner

@3C-SCSU 3C-SCSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback >> (2) > {5: +836/-0} [ For better code and project consistency, do the following changes. ]

Clean Code - Project consistency:

  1. change name of the file from: gaussiannb_jax_model.pkl
  • to the clearer file name: trained_classifier_gnb_jax.pkl
  1. change name of the file from: gaussiannb_jax_train.ipynb
  • to the clearer file name: instructions_log_gnb_jax.ipynb
  1. change name of the file from: gaussiannb_jax.py
  • to the clearer file name: algorithm_gnb_jax.py

@khimabaja
Copy link
Collaborator Author

Just updated the PR with the given comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants