Epic street editing #989
Merged
Epic street editing #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accepts type and index; does not yet accept custom object to represent segment and its constituent components; doesn't appear to apply child components correctly
-- instead look at working code to create new street-segments from an object in street-segment.js
to test, run on console:
> document.querySelector('[managed-street]').components['managed-street'].insertSegment(3, 'bike-lane');
Insert new segment
as a user i can detach a clone and the action is undo-able. if i save and reload I cannot undo or reattach the component unless i choose to add a new clone component or reset the segment completely.
Detach with multi command
allow ped and stencil detach
striping first cut
Co-Authored-By: Ben Kovitz <bkovitz@gmail.com>
Co-Authored-By: Ben Kovitz <bkovitz@gmail.com>
Co-Authored-By: Ben Kovitz <bkovitz@gmail.com>
…Managed-Street-format Converting default streets to managed street format
labels with manage-street event dispatcher
There was a problem hiding this comment.
Using events is indeed better here. You can probably simplify the code just listening on segment-width-changed on the parent entity, the event bubbles from the segment to the parent that is the managed-street entity.
Be careful to properly bind the listener function and use the same function when you remove the listener.
fix binding
I have to keep this in or it raises an error `Cannot read properties of undefined (reading 'width')`. My guess is there is a race condition such that when the scene is loaded the dom attribute is added but the a-frame component hasn't been initialized thus the segment is returned as matching the querySelector but not from a-frame getattribute? I changed the logic a bit to check if the street-segment component exist and to also return if no width for a segment:
```
const segmentWidth = segmentEl.getAttribute('street-segment')?.width;
if (!segmentWidth) return;
```
remove old streetplan loader
Streetplan to managed street
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.