Open mp fix for windows #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARMA_DONT_USE_WRAPPERS should change the behavior of carma that overrides memory management
chemiskyy
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solve 2 problems for windows version:
1 is solved by removing the gil release at the begining of the openmp parallelized loop. The parallelization seems to be efficient without needed to release the gil here.
2 is simply solved by adding a dependencies to mkl (and thus to inter-openmp package) at the build stage. If not, simcoon link to microsoft openmp version which cause problems when using with other libraries relying on mkl (blas or pypardiso for instance)