Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve export of local feature references #10

Closed
wants to merge 3 commits into from

Conversation

clausnagel
Copy link
Member

This PR proposes some improvements to the export of feature references:

  • Global feature references (val_reference_type == 2) are never resolved but only exported as Reference of type GLOBAL_REFERENCE. This is a result of #9 but is differently implemented in this PR.
  • Local feature references (val_reference_type == 1) can optionally be resolved. A corresponing option has been added to ExportOptions. This new option is true by default so that local references are resolved.
  • When exporting local feature references, the code has been improved to better detect cycles. If there are multiple references to the same local feature, the feature is only exported once. All other references are exported as Reference of type LOCAL_REFERENCE.

# Conflicts:
#	citydb-operation/src/main/java/org/citydb/operation/exporter/hierarchy/HierarchyBuilder.java
@clausnagel clausnagel closed this Dec 17, 2023
@clausnagel clausnagel deleted the export-local-references branch December 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant