-
Notifications
You must be signed in to change notification settings - Fork 7
DIscrete Optimization, Smooth Functional Maps, Bijective ZoomOut #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 81.08% 82.16% +1.08%
==========================================
Files 45 45
Lines 1385 1632 +247
==========================================
+ Hits 1123 1341 +218
- Misses 262 291 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR introduces three additional refinement methods from:
[1] MapTree: Recovering Multiple Solutions in the Space of Maps (https://arxiv.org/abs/2006.02532)
[2] Discrete Optimization for Shape Matching (https://www.lix.polytechnique.fr/~maks/papers/SGP21_DiscMapOpt.pdf)
[3] Smooth Non-Rigid Shape Matching via Effective Dirichlet Energy Optimization (https://arxiv.org/abs/2210.02870)
Some of these methods extend the conversion modules and refinement modules, needing to create a BijectiveItaretiveRefiner and other modifications of Converters.
[2] can be seen as a generalization of the ZoomOut algorithm. We could think to a redescign in which ZoomOut is a special instance of this algorithm. However, I think it would be cool to have also different implementations and then show that they are equivalent.
In general, we have to discuss whether the current structure of the converter (that takes a FM and return a p2p) can be extended to a common structure that can be used also when we want to input 2FM and return the two p2p in both directions, or it is better to create different converter classes for each purpose.