-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for on.soundcloud links #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested the sync method with these changes, and is returning the expected results. this seems like a fine solution.
@degendemolisher can you fix the linting errors called out in the autolinter run? You can run linting locally by doing |
Should I add requests in requirements_dev.txt? |
It would be nice to avoid adding more dependencies. Can you redo the part that requires |
There's |
one of the testing track id is invalid iirc, I changed it to something else and the test worked |
Cool, if you push up the changed test and it passes, I'll approve |
fixes #44
in resolve(),
get redirect link (soundcloud.com) if regex detects anything other than that (e.g. on.soundcloud.com)
regex here https://regex101.com/r/jK3gNT/1