Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for on.soundcloud links #45

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

degendemolisher
Copy link
Contributor

@degendemolisher degendemolisher commented Oct 19, 2024

fixes #44
in resolve(),
get redirect link (soundcloud.com) if regex detects anything other than that (e.g. on.soundcloud.com)
regex here https://regex101.com/r/jK3gNT/1

Copy link

@Aden720 Aden720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the sync method with these changes, and is returning the expected results. this seems like a fine solution.

@3jackdaws
Copy link
Owner

3jackdaws commented Nov 9, 2024

@degendemolisher can you fix the linting errors called out in the autolinter run?

You can run linting locally by doing make lint on the command line

@degendemolisher
Copy link
Contributor Author

Should I add requests in requirements_dev.txt?

@3jackdaws
Copy link
Owner

It would be nice to avoid adding more dependencies. Can you redo the part that requires requests to use urllib?

@3jackdaws
Copy link
Owner

There's get_obj_from and get_url utility functions in util.py

@degendemolisher
Copy link
Contributor Author

one of the testing track id is invalid iirc, I changed it to something else and the test worked

@3jackdaws
Copy link
Owner

Cool, if you push up the changed test and it passes, I'll approve

@3jackdaws 3jackdaws merged commit ccdff48 into 3jackdaws:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no support for 'https://on.soundcloud.com' type links
3 participants