Fix phpstan

3liz · Oct 18, 2024 · ebfb826 · ebfb826
1 parent 0699c46
commit ebfb826
Show file tree

Hide file tree

Showing 5 changed files with 632 additions and 633 deletions.
diff --git a/.github/workflows/php-stan.yml b/.github/workflows/php-stan.yml
@@ -30,8 +30,9 @@ jobs:
         uses: shivammathur/setup-php@v2
         # About the PHP version, do not forget to change in PHP Unit as well
         with:
-          php-version: '8.0'
+          php-version: '8.2'
           tools: phpstan:1.11.11
+          ini-values: error_reporting=22527
 
       - name: Cache dependencies
         uses: actions/cache@v4
@@ -50,7 +51,7 @@ jobs:
 
       - name: Run PHPStan
         id: test-phpstan
-        run: phpstan analyse -c ../phpstan.neon
+        run: phpstan analyse -c ../phpstan-ci.neon
 
       - name: Notify in case of failure
         uses: peter-evans/commit-comment@v3

diff --git a/lizmap/modules/lizmap/classes/lizmap.class.php b/lizmap/modules/lizmap/classes/lizmap.class.php
@@ -137,7 +137,7 @@ public static function getRepositoryList()
     public static function getRepositoryProperties()
     {
         trigger_error('This method is deprecated. Please use the lizmapRepository::getProperties() method.', E_DEPRECATED);
-
+        // @phpstan-ignore deadCode.unreachable
         return lizmapRepository::$properties;
     }
 
@@ -150,7 +150,7 @@ public static function getRepositoryProperties()
     public static function getRepositoryPropertiesOptions()
     {
         trigger_error('This method is deprecated. Please use the lizmapRepository::getPropertiesOptions() method.', E_DEPRECATED);
-
+        // @phpstan-ignore deadCode.unreachable
         return lizmapRepository::$propertiesOptions;
     }