Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lizmap version to proxy request #3373

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Dec 16, 2022

Proxy Request currently use "Lizmap" as user-agent in request header, that can be usefull for OGC service

the PR add the current lizmap Version

Fix : #2044

Funded by 3liz

@github-actions github-actions bot added QGIS Server tests unit tests and docker configuration for tests labels Dec 16, 2022
@nworr nworr marked this pull request as ready for review December 16, 2022 12:56
@rldhont
Copy link
Collaborator

rldhont commented Jan 2, 2023

@nworr I think you have to rebase your branch to avoid conflict with phptan tests fixes.

@nworr nworr force-pushed the lizmap-version-in-user-agent branch from f05cc38 to 0cbfad2 Compare January 2, 2023 15:51
@laurentj laurentj self-requested a review January 6, 2023 13:32
@nworr nworr force-pushed the lizmap-version-in-user-agent branch from c2a2487 to f2c8aec Compare January 10, 2023 11:22
@rldhont
Copy link
Collaborator

rldhont commented Jan 25, 2023

@laurentj requested changes done.

@nworr nworr force-pushed the lizmap-version-in-user-agent branch 2 times, most recently from 86f8e4d to 69cedda Compare February 16, 2023 12:49
@Gustry Gustry added this to the 3.7.0 milestone Feb 20, 2023
@nworr nworr force-pushed the lizmap-version-in-user-agent branch from 69cedda to d314e6d Compare March 3, 2023 14:24
@nworr nworr marked this pull request as draft April 18, 2023 10:59
@rldhont
Copy link
Collaborator

rldhont commented Aug 21, 2023

@nworr it is ready for merging?

@nworr nworr force-pushed the lizmap-version-in-user-agent branch from d314e6d to c543795 Compare August 21, 2023 15:50
@nworr nworr added the run end2end If the PR must run end2end tests or not label Aug 21, 2023
@nworr nworr marked this pull request as ready for review August 21, 2023 16:20
@nworr
Copy link
Contributor Author

nworr commented Aug 21, 2023

rebased , and some tests fixed, ready to merge

@rldhont rldhont merged commit 09d64ce into 3liz:master Aug 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QGIS Server run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the version info to the Lizmap user-agent
4 participants