Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use circle for selection #3500

Closed
wants to merge 1 commit into from

Conversation

nboisteault
Copy link
Member

Funded by 3Liz

@github-actions github-actions bot added javascript Pull requests that update Javascript code tests unit tests and docker configuration for tests labels Feb 17, 2023
@rldhont
Copy link
Collaborator

rldhont commented Feb 20, 2023

Linked to #3479

@Gustry Gustry added this to the 3.7.0 milestone Feb 20, 2023
Comment on lines +150 to +155
featureWKT = `CIRCULARSTRING(
${center[0] - radius} ${center[1]},
${center[0]} ${center[1] + radius},
${center[0] + radius} ${center[1]},
${center[0]} ${center[1] - radius},
${center[0] - radius} ${center[1]})`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
featureWKT = `CIRCULARSTRING(
${center[0] - radius} ${center[1]},
${center[0]} ${center[1] + radius},
${center[0] + radius} ${center[1]},
${center[0]} ${center[1] - radius},
${center[0] - radius} ${center[1]})`;
featureWKT = `CURVEPOLYGON( CIRCULARSTRING(
${center[0] - radius} ${center[1]},
${center[0]} ${center[1] + radius},
${center[0] + radius} ${center[1]},
${center[0]} ${center[1] - radius},
${center[0] - radius} ${center[1]}) )`;

@3liz-bot 3liz-bot added the stale This ticket might be closed soon label Aug 21, 2023
@3liz-bot 3liz-bot closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code stale This ticket might be closed soon tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants