Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw: set feature's color individually + delete features individually #3539

Merged
merged 10 commits into from
Jul 21, 2023

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Mar 10, 2023

Funded by Lons-le-Saunier

simplescreenrecorder-2023-03-13_15.32.09.mp4

Fix #2421

@nboisteault nboisteault self-assigned this Mar 10, 2023
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Mar 10, 2023
@nboisteault nboisteault added this to the 3.7.0 milestone Mar 10, 2023
@nboisteault nboisteault added enhancement sponsored development This development has been funded labels Mar 10, 2023
@nboisteault nboisteault marked this pull request as ready for review March 14, 2023 15:13
@rldhont
Copy link
Collaborator

rldhont commented Mar 15, 2023

Tests ?

@Gustry Gustry self-requested a review March 15, 2023 10:33
@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Mar 20, 2023
@rldhont rldhont added the run end2end If the PR must run end2end tests or not label May 30, 2023
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it hard to see if the feature is selected or not. Possible to show like in QGIS some nodes from the geometry highlighted ? Open to discuss

I would add in the "Edit" tooltip saying that multiple features can be selected with "shift" ?

Is this white space needed at the bottom ?
image

image

@nboisteault
Copy link
Member Author

nboisteault commented Jul 21, 2023

I find it hard to see if the feature is selected or not. Possible to show like in QGIS some nodes from the geometry highlighted ? Open to discuss

I would add in the "Edit" tooltip saying that multiple features can be selected with "shift" ?

Is this white space needed at the bottom ? image

image

@Gustry What about Edit (hold "Shift" to select multiple features)?

@Gustry
Copy link
Member

Gustry commented Jul 21, 2023

@Gustry What about Edit (hold "Shift" to select multiple features)?

Yes

Side note, can you add tooltip on the "Distance" label and widget (same for "angle"), explaining the concept ? I think while drawing rectangle, these settings are not needed, no ?

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try this new one, but from my last comments, it seems solved ?
Good

@nboisteault nboisteault merged commit 46a5043 into 3liz:master Jul 21, 2023
8 of 9 checks passed
@nboisteault nboisteault deleted the draw-distinct-color branch July 21, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not sponsored development This development has been funded tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draw tool - same color for all drawings
3 participants