Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing new JS Baselayers extraction and usage #3795

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Fixing new JS Baselayers extraction and usage #3795

merged 9 commits into from
Jul 21, 2023

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Jul 20, 2023

Capture d’écran 2023-07-20 à 17 14 21

  • Checking that empty group are not keeping as base layer
  • Correctly identify WMTS datasource
  • Fixing Config LayreTree module
  • Using Enums for base layer types
  • Creating new classes in State BaseLayer module to correctly create Openlayers Layers for base layers

@rldhont rldhont added javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Jul 20, 2023
@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Jul 20, 2023
@github-actions github-actions bot added this to the 3.7.0 milestone Jul 20, 2023
@rldhont rldhont marked this pull request as ready for review July 21, 2023 08:18
@rldhont
Copy link
Collaborator Author

rldhont commented Jul 21, 2023

@nboisteault ready for review

Gustry
Gustry reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try, I will test after

tests/qgis-projects/tests/base_layers_user_defined.qgs.cfg Outdated Show resolved Hide resolved
@rldhont rldhont merged commit 104beba into 3liz:master Jul 21, 2023
9 checks passed
@rldhont rldhont deleted the js-fix-baselayers branch July 21, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Gustry left review comments

@nboisteault nboisteault Awaiting requested review from nboisteault

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rldhont @Gustry