Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QgisProject.php #3811

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Update QgisProject.php #3811

merged 2 commits into from
Jul 30, 2023

Conversation

Antoviscomi
Copy link
Contributor

@Antoviscomi Antoviscomi commented Jul 28, 2023

Ticket : fix #3809

@github-actions github-actions bot added this to the 3.7.0 milestone Jul 28, 2023
@Antoviscomi
Copy link
Contributor Author

@nworr this PR it's also related to #3810

@Gustry Gustry added backport release_3_5 php Pull requests that update Php code labels Jul 28, 2023
@laurentj laurentj self-requested a review July 30, 2023 10:30
Copy link
Collaborator

@laurentj laurentj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this patch.

But this is not enough, there are other line of code with the same issue. I will provide an other patch.

@laurentj laurentj merged commit 698b406 into 3liz:master Jul 30, 2023
12 checks passed
@3liz-bot
Copy link
Contributor

The backport to release_3_5 failed:

The process '/usr/bin/git' failed with exit code 128
stderr
error: commit 82e403466015ff8ff465c687251e6e4f5d98523a is a merge but no -m option was given.
fatal: cherry-pick failed

stdout
Auto-merging lizmap/modules/lizmap/lib/Project/QgisProject.php
[backport-3811-to-release_3_5 a8f6a7b30] Update QgisProject.php
 Author: Antonio Viscomi <Antoviscomi@users.noreply.github.com>
 Date: Fri Jul 28 12:24:53 2023 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_5 release_3_5
# Navigate to the new working tree
cd .worktrees/backport-release_3_5
# Create a new branch
git switch --create backport-3811-to-release_3_5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 10cf3dd03e51798689d5bde127f1d031dcbcdcee,82e403466015ff8ff465c687251e6e4f5d98523a
# Push it to GitHub
git push --set-upstream origin backport-3811-to-release_3_5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_5

Then, create a pull request where the base branch is release_3_5 and the compare/head branch is backport-3811-to-release_3_5.

@3liz-bot
Copy link
Contributor

The backport to release_3_6 failed:

The process '/usr/bin/git' failed with exit code 128
stderr
error: commit 82e403466015ff8ff465c687251e6e4f5d98523a is a merge but no -m option was given.
fatal: cherry-pick failed

stdout
Auto-merging lizmap/modules/lizmap/lib/Project/QgisProject.php
[backport-3811-to-release_3_6 93c4ca066] Update QgisProject.php
 Author: Antonio Viscomi <Antoviscomi@users.noreply.github.com>
 Date: Fri Jul 28 12:24:53 2023 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_6 release_3_6
# Navigate to the new working tree
cd .worktrees/backport-release_3_6
# Create a new branch
git switch --create backport-3811-to-release_3_6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 10cf3dd03e51798689d5bde127f1d031dcbcdcee,82e403466015ff8ff465c687251e6e4f5d98523a
# Push it to GitHub
git push --set-upstream origin backport-3811-to-release_3_6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_6

Then, create a pull request where the base branch is release_3_6 and the compare/head branch is backport-3811-to-release_3_6.

@Antoviscomi
Copy link
Contributor Author

Thank you for this patch.

But this is not enough, there are other line of code with the same issue. I will provide an other patch.

Many thanks @laurentj

@laurentj
Copy link
Collaborator

patchs backported manually into Lizmap 3.5 and 3.6.

@Antoviscomi Antoviscomi deleted the patch-1 branch July 30, 2023 11:24
@Antoviscomi Antoviscomi restored the patch-1 branch July 30, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed backport php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please review the php var definition code in QgisProject.php and WMSRequest.php in 3.6.4 as in 3.7.0-alpha2
4 participants