check project scales and replace scale 0 with scale 1 #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nworr
force-pushed
the
normalize-prj-scale-lizmaptiler
branch
from
5e4e520
to
f2fcfb6
Compare
nworr
force-pushed
the
normalize-prj-scale-lizmaptiler
branch
from
f2fcfb6
to
70a280b
Compare
mdouchin
reviewed
Jul 31, 2023
Co-authored-by: mdouchin <mdouchin@3liz.com>
mdouchin
approved these changes
Jul 31, 2023
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user set the projects min scale to 0, it leads to a fatal "Division by zero" error :
see
lizmap-web-client/lizmap/modules/lizmap/classes/lizmapTiler.class.php
Line 256 in 68ab410
scaledenomiator will be divided until having out of bound value : 0
Fix is done on the plugin side 3liz/lizmap-plugin@392299a, but old projects conf may still have the 0 value
Funded by 3Liz