Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] reduce mainLizmap dependencies #3857

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

[JavaScript] reduce mainLizmap dependencies #3857

wants to merge 14 commits into from

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Aug 24, 2023

Remove dependencies of Globals mainLizmap singleton

@rldhont rldhont added javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Aug 24, 2023
@github-actions github-actions bot added this to the 3.7.0 milestone Aug 24, 2023
@rldhont rldhont force-pushed the js-reduce-mainlizmap-dependencies branch 2 times, most recently from 77c8ba2 to 89ff386 Compare August 28, 2023 06:38
@Gustry Gustry modified the milestones: 3.7.0, 3.8 Nov 23, 2023
@Gustry Gustry modified the milestones: 3.8.0, 3.9 May 14, 2024
@github-actions GitHub Actions
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jun 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 8, 2024
@github-actions GitHub Actions
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 15, 2024
@rldhont rldhont force-pushed the js-reduce-mainlizmap-dependencies branch 4 times, most recently from b395ae3 to 8119c9c Compare July 22, 2024 14:57
@github-actions GitHub Actions
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added the stale This ticket might be closed soon label Jul 22, 2024
@rldhont rldhont force-pushed the js-reduce-mainlizmap-dependencies branch from 8119c9c to 87670d1 Compare July 24, 2024 12:32
@github-actions github-actions bot removed the stale This ticket might be closed soon label Jul 24, 2024
@github-actions GitHub Actions
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added the stale This ticket might be closed soon label Jul 29, 2024
@rldhont rldhont force-pushed the js-reduce-mainlizmap-dependencies branch 2 times, most recently from 1abf6af to bf4d277 Compare July 31, 2024 11:24
@github-actions github-actions bot removed the stale This ticket might be closed soon label Jul 31, 2024
@rldhont rldhont force-pushed the js-reduce-mainlizmap-dependencies branch 3 times, most recently from e94e0e7 to 4ea554e Compare August 1, 2024 07:04
@github-actions GitHub Actions
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added the stale This ticket might be closed soon label Sep 30, 2024
@rldhont
[JavaScript] Remove mainLizmap from Legend module
81a5b79
@rldhont
[JavaScript] Remove mainLizmap from Popup module
a869965
@rldhont
JSDoc: The lizmap Map State
8ebdea7
@rldhont
[JavaScript] Remove mainLizmap from Map module
577a033
@rldhont
[JavaScript] Remove mainLizmap from Edition module
a2409c6
@rldhont
[JavaScript] Remove mainLizmap from Geolocation module
6ad6d4a
@rldhont
[JavaScript] Remove mainLizmap from GeolocationSurvey module
87ca8b3
@rldhont
[JavaScript] Remove mainLizmap from FeaturesTable module
70dce00
@rldhont
[JavaScript] Remove mainLizmap from SelectionTool module
d6c5ae2
@rldhont
[JavaScript] Remove mainLizmap from Digitizing module
27ce279
@rldhont
[JavaScript] Remove mainLizmap from Snapping module
f83bac8
@rldhont
[JavaScript] Remove mainLizmap from Search module
909a4b7
@rldhont
[JavaScript] Remove mainLizmap from Tooltip module
1874990
@rldhont
[JavaScript] Remove mainLizmap from Action module
9935dd8
@rldhont rldhont force-pushed the js-reduce-mainlizmap-dependencies branch from 4ea554e to 9935dd8 Compare October 1, 2024 06:58
@github-actions github-actions bot removed the stale This ticket might be closed soon label Oct 2, 2024
@Gustry Gustry modified the milestones: 3.9.0, 3.10.0 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nboisteault nboisteault Awaiting requested review from nboisteault

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rldhont @Gustry