Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release_3_6] Dataviz - Do not display child plot in Popup when there is no data #3861

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

mind84
Copy link
Contributor

@mind84 mind84 commented Aug 29, 2023

Backport to release 3_6 #3854

When displaying the popup of an object containing child plots, if the layer has no child data associated with a specific plot, the loading bar must not be displayed but the plot should be hidden.

Ticket : fix #3799

Funded by Faunalia (https://www.faunalia.eu/)

@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Aug 29, 2023
@github-actions github-actions bot added this to the 3.6.6 milestone Aug 29, 2023
@Gustry Gustry added dataviz javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Aug 29, 2023
@Gustry
Copy link
Member

Gustry commented Aug 31, 2023

Thanks for fixing the tests and doing the backport

Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@Gustry Gustry merged commit 85f6ad3 into 3liz:release_3_6 Sep 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataviz javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants