Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release_3_6] [Bugfix] Load relations from embedded layers #3902

Closed
wants to merge 3 commits into from

Conversation

3liz-bot
Copy link
Contributor

Backport #3899
Authored by: @mind84

@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Sep 29, 2023
@github-actions github-actions bot added this to the 3.6.6 milestone Sep 29, 2023
@Gustry Gustry added bug run end2end If the PR must run end2end tests or not labels Sep 29, 2023
@Gustry
Copy link
Member

Gustry commented Sep 29, 2023

it seems the original PR was valid only for 3.7 ?
On 3.6, both phpunit and playwright are failing (not a false positive)

@rldhont
Copy link
Collaborator

rldhont commented Oct 2, 2023

I have backported 2 lines of code from this commit 81f600d

I have added

                    'relationName' => (string) $relationObj->name,
                    'relationId' => (string) $relationObj->id,

to https://github.com/3liz/lizmap-web-client/blob/release_3_6/lizmap/modules/lizmap/lib/Project/QgisProject.php#L1481

@mind84
Copy link
Contributor

mind84 commented Oct 3, 2023

it seems the original PR was valid only for 3.7 ? On 3.6, both phpunit and playwright are failing (not a false positive)

Hi @Gustry,

sorry, yes, I've not considered the backport to previous versions, I'll work on it.

@Gustry Gustry modified the milestones: 3.6.6, 3.6.7 Oct 4, 2023
@Gustry Gustry modified the milestones: 3.6.7, 3.6.8 Oct 12, 2023
@Gustry
Copy link
Member

Gustry commented Oct 12, 2023

As talked by email, the branch can't be updated by @mind84 because it's hosted on 3Liz repo. A new one will be opened.

@Gustry Gustry closed this Oct 12, 2023
@Gustry Gustry deleted the backport-3899-to-release_3_6 branch November 24, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug failed backport run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants