Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action: allow geometry drawn by user #4754

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Sep 16, 2024

Funded by WPD

simplescreenrecorder-2024-10-01_15.20.13.mp4

@nboisteault nboisteault self-assigned this Sep 16, 2024
@github-actions github-actions bot added this to the 3.9.0 milestone Sep 16, 2024
@nboisteault nboisteault added the run end2end If the PR must run end2end tests or not label Sep 17, 2024
@Gustry Gustry added the sponsored development This development has been funded label Sep 17, 2024
@nboisteault nboisteault force-pushed the action-digitizing branch 2 times, most recently from 3d5921c to 01715ca Compare September 19, 2024 14:44
@nboisteault nboisteault marked this pull request as ready for review October 1, 2024 09:35
@rldhont
Copy link
Collaborator

rldhont commented Oct 15, 2024

waiting for @mdouchin review!

Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.
Can you please improve the UI a bit :

  • use the same space between the left mini-dock border and the digitizing toolbar (and message underneath) as the space used for the combobox and "grey" description. It seems. Be careful about testing it with a without Bootstrap 5
  • we shoud probably remove the grey background color of the description and use a lighter style, for example a thin blue border as used in the editing form group
border: 1px solid var(--color-contrasted-elements-light);
border-radius: 5px;

Thanks !

@nboisteault nboisteault merged commit dff7c16 into 3liz:master Nov 5, 2024
13 checks passed
@nboisteault nboisteault deleted the action-digitizing branch November 5, 2024 14:52
@Gustry
Copy link
Member

Gustry commented Nov 5, 2024

Sorry @nboisteault I just tried this PR.

we should probably remove the grey background color

I can only agree with this proposition, the current grey background is legacy and still present.

AS talked with @rldhont and @mdouchin, if the geometry is set for the action, so the geometry is required. We shouldn't be able to launch the action without a geometry.
I think the "Launch" button should be disabled until we do not have a geometry. Otherwise, we have the error message set the SQL function code :

image

nboisteault added a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_9 enhancement run end2end If the PR must run end2end tests or not sponsored development This development has been funded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants