-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glossary: additional publication frequencies, incl. item_order #103
Conversation
By the way, is there way to use the item order in the attribute forms? |
I think there is a checkbox "Order by value" in the field form settings. |
That would sort alphabetically according to the label_xx field (i.e. the values shown in the dropdown list). Unless it is well hidden, there doesn’t seem to be an option for a separate sort key. |
I have changed the glossary terms introduced in this PR to begin with upper case letters. @Gustry Should I extend |
@Gustry Github says “This branch has conflicts that must be resolved” for Also, should I change case for existing terms (introduced before this PR) here, too? |
While we’re working on this PR, I’ve found 2 more additions to the glossary lying around in our local installation:
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en, item_order, label_fr, description_fr, label_it, description_it, label_es, description_es, label_de, description_de) VALUES ('link.type', 'directory', 'A directory', 'Directory on the local filesystem', NULL, NULL, NULL, NULL, NULL, NULL, NULL, 'Ein Ordner', 'Ein Ordner auf dem lokalen Dateisystem');
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en) VALUES ('link.mime', 'directory', 'inode/directory', 'Directory (not an official MIME type');
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en, item_order, label_fr, description_fr, label_it, description_it, label_es, description_es, label_de, description_de) VALUES ('link.type', 'ESRI:SHP', 'ESRI Shapefile', 'Vector layer in Shapefile format (.shp)', NULL, NULL, NULL, NULL, NULL, NULL, NULL, 'ESRI Shapefile', 'Vektorlayer im Shapefile-Format (.shp)'); |
Should I add these to the PR? |
79751b3
to
c56c251
Compare
I’ve rebased the glossary additions in the original PR onto version 1.2.1 and added the suggestions for 2 new link types in a new commit. |
Is there any work for me to do on this PR? |
Now all terms from ISO 19115 are implemented: https://www.geoportal-bw.de/documents/20147/754293/ISO_19115_Deutsch_Stand_08-12-2008.pdf table „B.5.18 MD_MaintenanceFrequencyCode“ Set version to 1.2.3 parent e032f23
* version in metadata.txt * capitalisation of glossary terms included in this PR (correcting capitalisation of existing terms to be discussed)
Also change item_order for publication_frequency “unknown”
Suggested by Ross McDonald @mixedbredie, issue 3liz#152 German and French translations from INSPIRE website https://inspire.ec.europa.eu/metadata-codelist/ResponsiblePartyRole
c56c251
to
5f8f315
Compare
* roles typically provided by German government metadata * frequencies greater than 1 year
I have extended this PR to include @mixedbredie’s suggestions from #152 (with German translations from the INSPIRE website) and the “unknown“ terms I have proposed in #159. |
I will have a look next week, very sorry for the delay ! |
Thank you! |
Could you decide whether to merge this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the huge delay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry again for the delay !
I approve for when the migration will be fixed (comment from my colleague)
As you are adding new features, we will make a 1.3.0 version. Can you switch to this migration file ? |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Great, thanks! |
Maybe you could add French translations for the new glossary terms before releasing the new version? I can’t speak French and I dare not use Google translate. ;-) |
Yes, I was planning to do that before releasing the new version. |
Now all publication frequency terms from ISO 19115 are implemented and translated to German:
https://www.geoportal-bw.de/documents/20147/754293/ISO_19115_Deutsch_Stand_08-12-2008.pdf
table „B.5.18 MD_MaintenanceFrequencyCode“
I’ve set the version to 1.2.0 and introduced a file
upgrade_to_1.2.0.sql
.