Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary: additional publication frequencies, incl. item_order #103

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

effjot
Copy link
Contributor

@effjot effjot commented Mar 4, 2022

Now all publication frequency terms from ISO 19115 are implemented and translated to German:
https://www.geoportal-bw.de/documents/20147/754293/ISO_19115_Deutsch_Stand_08-12-2008.pdf
table „B.5.18 MD_MaintenanceFrequencyCode“

I’ve set the version to 1.2.0 and introduced a file upgrade_to_1.2.0.sql.

pg_metadata/metadata.txt Outdated Show resolved Hide resolved
pg_metadata/install/sql/pgmetadata/90_GLOSSARY.sql Outdated Show resolved Hide resolved
@effjot
Copy link
Contributor Author

effjot commented Mar 10, 2022

By the way, is there way to use the item order in the attribute forms?

@Gustry
Copy link
Member

Gustry commented Mar 10, 2022

By the way, is there way to use the item order in the attribute forms?

I think there is a checkbox "Order by value" in the field form settings.

@effjot
Copy link
Contributor Author

effjot commented Apr 26, 2022

By the way, is there way to use the item order in the attribute forms?

I think there is a checkbox "Order by value" in the field form settings.

That would sort alphabetically according to the label_xx field (i.e. the values shown in the dropdown list). Unless it is well hidden, there doesn’t seem to be an option for a separate sort key.

@effjot
Copy link
Contributor Author

effjot commented Apr 26, 2022

I have changed the glossary terms introduced in this PR to begin with upper case letters.

@Gustry Should I extend upgrade_to_1.2.0.sql and 90_Glossary.sql so that the existing terms (introduced before this PR) are corrected, too? Or would you prefer this in a separate PR?

@effjot
Copy link
Contributor Author

effjot commented May 2, 2022

@Gustry Github says “This branch has conflicts that must be resolved” for upgrade_to_1.2.0.sql. I think I need to rebase on upstream/master, correct?

Also, should I change case for existing terms (introduced before this PR) here, too?

@effjot
Copy link
Contributor Author

effjot commented Aug 17, 2022

While we’re working on this PR, I’ve found 2 more additions to the glossary lying around in our local installation:

  • file/link type for a directory (We use it to point to a folder on our fileserver containing additional documentation, e.g. legends, descriptions of data by the provider.)
  • file/link type for ESRI Shapefiles (still very common distribution format; we store a link to the original download source)
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en, item_order, label_fr, description_fr, label_it, description_it, label_es, description_es, label_de, description_de) VALUES ('link.type', 'directory', 'A directory', 'Directory on the local filesystem', NULL, NULL, NULL, NULL, NULL, NULL, NULL, 'Ein Ordner', 'Ein Ordner auf dem lokalen Dateisystem');
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en) VALUES ('link.mime', 'directory', 'inode/directory', 'Directory (not an official MIME type');
INSERT INTO pgmetadata.glossary (field, code, label_en, description_en, item_order, label_fr, description_fr, label_it, description_it, label_es, description_es, label_de, description_de) VALUES ('link.type', 'ESRI:SHP', 'ESRI Shapefile', 'Vector layer in Shapefile format (.shp)', NULL, NULL, NULL, NULL, NULL, NULL, NULL, 'ESRI Shapefile', 'Vektorlayer im Shapefile-Format (.shp)');

@effjot
Copy link
Contributor Author

effjot commented Aug 19, 2022

While we’re working on this PR, I’ve found 2 more additions to the glossary lying around in our local installation:
* file/link type for a directory (We use it to point to a folder on our fileserver containing additional documentation, e.g. legends, descriptions of data by the provider.)
* file/link type for ESRI Shapefiles (still very common distribution format; we store a link to the original download source)

Should I add these to the PR?

@effjot
Copy link
Contributor Author

effjot commented Sep 11, 2022

I’ve rebased the glossary additions in the original PR onto version 1.2.1 and added the suggestions for 2 new link types in a new commit.

@effjot
Copy link
Contributor Author

effjot commented Dec 5, 2022

Is there any work for me to do on this PR?
Thanks!

@effjot
Copy link
Contributor Author

effjot commented May 15, 2023

Is this PR ready for merging? @Gustry @mdouchin

I could also add the glossary items in #152.

Now all terms from ISO 19115 are implemented:
https://www.geoportal-bw.de/documents/20147/754293/ISO_19115_Deutsch_Stand_08-12-2008.pdf
table „B.5.18 MD_MaintenanceFrequencyCode“

Set version to 1.2.3

parent e032f23
* version in metadata.txt
* capitalisation of glossary terms included in this PR
  (correcting capitalisation of existing terms to be discussed)
Also change item_order for publication_frequency “unknown”
@effjot effjot force-pushed the PR-glossary-terms-frequency branch from c56c251 to 5f8f315 Compare June 19, 2023 15:21
* roles typically provided by German government metadata
* frequencies greater than 1 year
@effjot
Copy link
Contributor Author

effjot commented Jun 19, 2023

I have extended this PR to include @mixedbredie’s suggestions from #152 (with German translations from the INSPIRE website) and the “unknown“ terms I have proposed in #159.
Also, there are some more roles and frequencies we’ve encountered and would suggest as an addition to the glossary.

@Gustry and @mdouchin: could this PR be merged?
Thank you!

@effjot
Copy link
Contributor Author

effjot commented Sep 1, 2023

Just a little ping if this PR could be merged. ;-)
@Gustry @mdouchin

@Gustry
Copy link
Member

Gustry commented Sep 19, 2023

I will have a look next week, very sorry for the delay !

@effjot
Copy link
Contributor Author

effjot commented Sep 19, 2023

Thank you!

@effjot
Copy link
Contributor Author

effjot commented Nov 26, 2023

Could you decide whether to merge this PR? Thanks!

Copy link
Contributor

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the huge delay

pg_metadata/install/sql/upgrade/upgrade_to_1.2.0.sql Outdated Show resolved Hide resolved
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry again for the delay !

I approve for when the migration will be fixed (comment from my colleague)

@Gustry
Copy link
Member

Gustry commented Dec 1, 2023

As you are adding new features, we will make a 1.3.0 version. Can you switch to this migration file ?

@effjot
Copy link
Contributor Author

effjot commented Dec 2, 2023

Thanks!
I’ll have a look into the migration files soon.

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Gustry Gustry merged commit e490bbe into 3liz:master Dec 21, 2023
4 checks passed
@effjot
Copy link
Contributor Author

effjot commented Dec 21, 2023

Great, thanks!

@effjot
Copy link
Contributor Author

effjot commented Dec 22, 2023

Maybe you could add French translations for the new glossary terms before releasing the new version? I can’t speak French and I dare not use Google translate. ;-)

@Gustry
Copy link
Member

Gustry commented Dec 22, 2023

Yes, I was planning to do that before releasing the new version.
I guess you want to update/rebase #85 so we avoid having conflict together ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants