RequestHandlerDelegate.contentTypes and RequestHandler.links #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the proposed fixes and changes are actually at hand. This PR is not relevant anymore. |
… types this handler can serve, default to JSON. QgsServerOgcApiHandler::contentTypes not available in Python bindings
…given request The QgsServerOgcApiHandler::links not available in Python bindings
rldhont
force-pushed
the
request-handler-links
branch
from
c86f150 to
4f466fc
Compare
|
@dmarteau which code are duplicated ? |
dmarteau
reviewed
Sep 3, 2021
| return self._parent.href(self._context,path,extension) | ||
| return self._parent.href(self._context, path, extension) | ||
|
|
||
| def links(self) -> List[str]: |
There was a problem hiding this comment.
There is no point to implement this here, apiutils is not a global library and will never be one because of the way Qgis plugin are distributed (with no dependencies)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide self and alternate links the RequestHandlerDelegate.contentTypes and RequestHandler.links have been implemented because QgsServerOgcApiHandler::contentTypes and QgsServerOgcApiHandler::links are not available in Python bindings.
This PR is an extraction of #7