Save style in database #77
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdrillin
force-pushed
the
saveStyle
branch
5 times, most recently
from
21d1f7a
to
3a7d0a6
Compare
rldhont
reviewed
Oct 14, 2020
pdrillin
force-pushed
the
saveStyle
branch
2 times, most recently
from
3963548
to
42123d0
Compare
pdrillin
force-pushed
the
saveStyle
branch
3 times, most recently
from
e249799
to
17b9164
Compare
Gustry
reviewed
Oct 15, 2020
| @@ -168,12 +190,24 @@ def processAlgorithm(self, parameters, context, feedback): | |||
| output_layers.append(result.id()) | |||
|
|
|||
| # add attribute tables | |||
| style = self.parameterAsBool(parameters, self.STYLE, context) | |||
| save_style = self.parameterAsBool(parameters, self.SAVE_STYLE, context) | |||
There was a problem hiding this comment.
Je pense que c'est mieux de vérifier ici si not style and save_style, cela évite d'afficher plusieurs fois le message d'erreur qui est dans la boucle (puise que cela sera strictement le même message)
Utiliser feedback.reportError
There was a problem hiding this comment.
avec report error le script continue ? @Gustry
There was a problem hiding this comment.
Le script ne s'arrête qu'avec une exception QgsProcessingException. Le feedback, c'est juste pour faire du reporting.
| output_layers.append(result.id()) | ||
| if style and save_style: | ||
| msg_style = "Style for " + x + " successfully loaded and saved in database" | ||
| result.saveStyleToDatabase(result.name(), 'default description', True, '') |
There was a problem hiding this comment.
Mettre une meilleure description, comme par ex : "Véloroute - segment"
veloroutes_voies_vertes/processing/config/save_style_database.py
Outdated
Show resolved
Hide resolved
veloroutes_voies_vertes/processing/structure/create_database_structure.py
Outdated
Show resolved
Hide resolved
veloroutes_voies_vertes/processing/structure/upgrade_database_structure.py
Outdated
Show resolved
Hide resolved
veloroutes_voies_vertes/processing/config/save_style_database.py
Outdated
Show resolved
Hide resolved
| } | ||
| for lay in layers: | ||
| layer = QgsProject.instance().mapLayer(lay) | ||
| layer.saveStyleToDatabase(layer.name(), 'default description', True, '') |
There was a problem hiding this comment.
- Ce code plantera pour une couche qui n'est pas QgsVectorLayer
- L'utilisateur a potentiellement plusieurs couches dans son projet QGIS, qui n'ont rien à voir avec VVV et qui ne sont pas de la base de données, il faut donc utiliser uniquement les couches VVV
- Mettre une meilleure description par ex
Extension Véloroute - segment?
rldhont
requested changes
Oct 15, 2020
| @@ -168,12 +190,24 @@ def processAlgorithm(self, parameters, context, feedback): | |||
| output_layers.append(result.id()) | |||
|
|
|||
| # add attribute tables | |||
| style = self.parameterAsBool(parameters, self.STYLE, context) | |||
| save_style = self.parameterAsBool(parameters, self.SAVE_STYLE, context) | |||
pdrillin
force-pushed
the
saveStyle
branch
8 times, most recently
from
b1727aa
to
d63b427
Compare
rldhont
reviewed
Oct 16, 2020
Comment on lines
+77
to
+79
| for lay in layers: | ||
| if lay in layers_required: | ||
| layer = layers[lay] |
There was a problem hiding this comment.
Ici ça ne peut pas marcher, @drillinP as-tu tester cet algo ?
Gustry
reviewed
Oct 16, 2020
| if not style and save_style: | ||
| feedback.reportError( | ||
| "Le style des couches ne peut pas être chargé en base car aucun " | ||
| " style n'est importé" |
There was a problem hiding this comment.
Suggested change
| " style n'est importé" | |
| "style n'est importé" |
Sinon il y a un double espace, car il est déjà présent L198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description