Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve redis server status metrics #270

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Improve redis server status metrics #270

merged 2 commits into from
Oct 4, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 4, 2023

Improves the redis info metrics to provide the same information that the Sentinel status provides.

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Oct 4, 2023
@3scale-robot 3scale-robot requested review from raelga and slopezz October 4, 2023 08:15
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 4, 2023
@slopezz
Copy link
Member

slopezz commented Oct 4, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 128482d25db0f4e19bc5131899c64bd6b3166663

@3scale-robot 3scale-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@3scale-robot 3scale-robot requested review from raelga and slopezz October 4, 2023 11:18
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9f7c6b254ddd5104307ec2f6e23eab45c6da1151

@roivaz
Copy link
Member Author

roivaz commented Oct 4, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@3scale-robot 3scale-robot merged commit 7592d08 into main Oct 4, 2023
@3scale-robot 3scale-robot deleted the redis-status-metrics branch October 4, 2023 13:57
@roivaz
Copy link
Member Author

roivaz commented Nov 3, 2023

Related to https://github.com/3scale/platform/issues/868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @slopezz @3scale-robot @raelga