Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test metrics hierarchies #893

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mastastny
Copy link
Contributor

Error was caused by deletion of custom_ui_backend while it was still registered in custom_ui_product.
This fix assures, that teardown of custom_ui_product fixtures will be executed before teardown of custom_ui_backend.

@mastastny mastastny requested a review from a team as a code owner November 22, 2024 12:31
@mastastny mastastny force-pushed the fix_test_metrics_hierarchies branch from 64b13ce to 6252fd0 Compare November 22, 2024 14:32
@dhlavac dhlavac added this to the v2.15 milestone Nov 26, 2024
@dhlavac
Copy link
Collaborator

dhlavac commented Nov 28, 2024

Adding dependency for this teardown is kind of no go, I would suggest using one of below approaches:

  • change finalizer - decorate it with backoff, create custom finalizer
  • create custom_ui_service that binds by default product and backend but is parametrized and in case of this test it will be created without bind, but finalizer will handle that
  • extend the test with not only adding but also unassigning backend from product

@mastastny mastastny force-pushed the fix_test_metrics_hierarchies branch from 67b0f94 to 4d163e2 Compare November 28, 2024 10:11
@dhlavac dhlavac merged commit 8b39dd3 into 3scale-qe:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants