🚧🥒 Reduce Capybara / Cucumber config #3911
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostadinov
reviewed
Oct 9, 2024
features/support/capybara.rb
Outdated
| end | ||
| # Before '@javascript' do | ||
| # Capybara.current_driver = DEFAULT_JS_DRIVER | ||
| # end | ||
|
|
||
| Before '@chrome' do |
There was a problem hiding this comment.
maybe
Suggested change
| Before '@chrome' do | |
| Before '@foreground' do |
akostadinov
reviewed
Oct 9, 2024
|
|
||
| # Needed because cucumber-rails requires capybara/cucumber | ||
| # https://github.com/cucumber/cucumber-rails/blob/7b47bf1dda3368247bf2d45bcb17a224e80ec6fd/lib/cucumber/rails/capybara.rb#L3 | ||
| # https://github.com/teamcapybara/capybara/blob/2.18.0/lib/capybara/cucumber.rb#L17-L19 | ||
| Before '@javascript' do | ||
| Capybara.current_driver = DEFAULT_JS_DRIVER | ||
| end |
There was a problem hiding this comment.
I remember this @javascript tag was heavily patched by us. I had some updates to upstream capybara/cucumber but IIRC it required Ruby 3. So I can check about this now we have Ruby 3.1 merged.
josemigallas
force-pushed
the
simple_capybara_config
branch
6 times, most recently
from
a930d27
to
e185ba4
Compare
akostadinov
reviewed
Oct 10, 2024
.circleci/config.yml
Outdated
| @@ -91,7 +91,7 @@ attach-to-workspace: &attach-to-workspace | |||
| at: . | |||
|
|
|||
| system-builder-ruby31: &system-builder-ruby31 | |||
| image: quay.io/3scale/system-builder:stream8-ruby3.1 | |||
| image: quay.io/3scale/system-builder:stream8-ruby3.1-chrome126 | |||
There was a problem hiding this comment.
127+ didn't work with --disable-gpu? That's worrying.
There was a problem hiding this comment.
Yes it does. I was trying to fix current Circleci failures by downgrading chromedriver, with no success.
josemigallas
force-pushed
the
simple_capybara_config
branch
from
3f03640
to
154f5c9
Compare
jlledom
reviewed
Oct 29, 2024
| Capybara.current_driver = DEFAULT_JS_DRIVER | ||
| end | ||
| Capybara.javascript_driver = :headless_chrome | ||
| Capybara.match = :prefer_exact # TODO: this is Capybara v1 default, we should use :one or :smart |
There was a problem hiding this comment.
Why not change it to :one or :smart directly?
| options.add_argument('--host-resolver-rules=MAP * ~NOTFOUND , EXCLUDE *localhost*') | ||
| options.add_argument('--disable-search-engine-choice-screen') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capybara configuration has grown a lot recently and I believe we're building on top of an outdated setup. Capybara/Selenium offers default features that we can use.