Separate build release CI steps #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the setup stage reusable across different workflows
This workflow runs on push, PR, or workflow dispatch, and it runs the prettier formatting check.
You never know when you'll accidentally `git add -a` ...
|
By the way, I made sure to test the build & release CI on a separate branch on my fork, and it passed through everything except pushing to the VSX registry (obviously, since I don't have a PAT). |
|
Looks good, thank you! Don't worry about the formatting, I'll fix it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19.
Please let me know if I made a mistake or if I took too many liberties in this PR.
Also, the prettier check step is definitely working. It's complaining about 12 files. Should I format them in this PR or a separate one?