Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): 行選択のアクセシビリティ改善 #1498

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented Jan 5, 2024

チケット

実装内容

  • 選択できる行を使ったTableのアクセシビリティ改善
    • 全選択Checkboxのラベル名がカラムの名称になってしまって読み上げが煩雑なのでaria-labelを使って改善
    • Checkbox, Radioの読み上げ時に画像にaria-hiddenが入っていないため読み上げが煩雑なのを改善
    • チェックボックスの名前が行の名称と結びついていない件は一旦問題なさそうなのでこのままにする

スクリーンショット

変更前 変更後

相談内容(あれば)

Copy link

changeset-bot bot commented Jan 5, 2024

⚠️ No Changeset found

Latest commit: cee9a26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cee9a26
Status: ✅  Deploy successful!
Preview URL: https://cde9c2bf.for-ui.pages.dev
Branch Preview URL: https://fix-enhance-a11y-selectable.for-ui.pages.dev

View logs

@Qs-F Qs-F marked this pull request as draft January 5, 2024 12:52
Copy link
Contributor

@locona locona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: 行選択のアクセシビリティ改善
2 participants