Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6.0 support #63

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Swift 6.0 support #63

wants to merge 5 commits into from

Conversation

417-72KI
Copy link
Owner

No description provided.

Copy link

github-actions bot commented Sep 27, 2024

Fails
🚫

danger-swift failed.

Log

/tmp/danger/23684DF3-E633-4C97-904E-61BFF764628A/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
 1 | import Danger
   |        `- error: no such module 'Danger'
 2 | 
 3 | import Foundation
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /tmp/danger/23684DF3-E633-4C97-904E-61BFF764628A/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against 6d04e23

Comment on lines 9 to 11
"6.0": "main",
"5.10": "main",
"5.9": "main",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that SwiftLint requires Swift 6 on Linux, I wonder if it would work with these changes...

Suggested change
"6.0": "main",
"5.10": "main",
"5.9": "main",
"6.0": "main",
"5.10": "0.57.0",
"5.9": "0.57.0",

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already changed them in #65 and not rebased yet 😅

@jagreenwood
Copy link

👍 looks like 6.0 works. Could we release that since Swift 6.0 is the current release and PR 6.1 separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants