Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update major changes for defaults #160

Merged
merged 6 commits into from
Jan 17, 2025
Merged

feat: Update major changes for defaults #160

merged 6 commits into from
Jan 17, 2025

Conversation

GeekMasher
Copy link
Contributor

  • i32 -> u64 for Primary and Foreign Keys
  • Update Value defaults

- i32 -> u64 for Primary and Foreign Keys
- Update Value defaults
@GeekMasher GeekMasher requested a review from Copilot December 19, 2024 19:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • geekorm-core/src/builder/values/valsemver.rs: Evaluated as low risk
Comments suppressed due to low confidence (5)

geekorm-core/src/builder/values/mod.rs:77

  • Changing the Integer variant from i32 to i64 may cause issues if other parts of the codebase expect i32 values. Ensure that all usages of Value::Integer are updated accordingly to handle i64 values.
Integer(i64),

geekorm-core/src/builder/values/mod.rs:80

  • Changing the Boolean variant from i32 to u8 may cause issues if other parts of the codebase expect i32 values. Ensure that all usages of Value::Boolean are updated accordingly to handle u8 values.
Boolean(u8),

geekorm-core/src/builder/values/mod.rs:82

  • Changing the Identifier variant from String to u64 may cause issues if other parts of the codebase expect String values. Ensure that all usages of Value::Identifier are updated accordingly to handle u64 values.
Identifier(u64),

geekorm-core/src/backends/libsql.rs:239

  • The error message 'NoRowsFound' should include the query string to provide more context.
return Err(crate::Error::NoRowsFound(query.to_string()));

geekorm-core/src/backends/libsql.rs:398

  • This change assumes that libsql::Value::Integer can hold a u64 value, which may not be true. Ensure the type compatibility or handle potential overflows.
libsql::Value::Integer(value) => Value::Integer(value),

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

geekorm-core/src/backends/libsql.rs Show resolved Hide resolved
@GeekMasher GeekMasher enabled auto-merge (rebase) December 19, 2024 20:28
@GeekMasher GeekMasher merged commit 9fc3cee into main Jan 17, 2025
10 checks passed
@GeekMasher GeekMasher deleted the defaults-keys branch January 17, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant