Merge pull request #180 from 42organization/GGBE-211-admin-user-put

[fix] GGBE-211 user detail update수정
42organization · Jul 19, 2023 · d730521 · d730521
2 parents 65dd1f5 + 00bb300
commit d730521
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/main/java/com/gg/server/admin/rank/service/RankRedisAdminService.java b/src/main/java/com/gg/server/admin/rank/service/RankRedisAdminService.java
@@ -46,7 +46,13 @@ public void deleteSeasonRankBySeasonId(Long seasonId) {
 
     public void updateRankUser(String hashKey, String zsetKey, Long userId, RankRedis userRank) {
         rankRedisRepository.updateRankData(hashKey, userId, userRank);
-        rankRedisRepository.deleteFromZSet(zsetKey, userId);
-        rankRedisRepository.addToZSet(zsetKey, userId, userRank.getPpp());
+        if (userPlayedRank(userRank)){
+            rankRedisRepository.deleteFromZSet(zsetKey, userId);
+            rankRedisRepository.addToZSet(zsetKey, userId, userRank.getPpp());
+        }
+    }
+
+    private boolean userPlayedRank(RankRedis userRank) {
+        return (userRank.getWins() + userRank.getLosses()) != 0;
     }
 }
diff --git a/src/main/java/com/gg/server/admin/user/controller/UserAdminController.java b/src/main/java/com/gg/server/admin/user/controller/UserAdminController.java
@@ -61,6 +61,6 @@ public ResponseEntity userUpdateDetail(@PathVariable String intraId,
         }
         userAdminService.updateUserDetail(intraId, updateUserInfo, imgData);
 
-        return new ResponseEntity(HttpStatus.OK);
+        return new ResponseEntity(HttpStatus.NO_CONTENT);
     }
 }