Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug] AgendaTeamAdmin에서 cancel 상태로 변경시에 Confirm 팀일경우 currentTeam이 줄어들지 않는 버그 발생 #1004 #1005

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Sep 6, 2024

📌 개요

  • adminTeamCancel confirm 팀이었을 경우 agenda에서 CurrentTeam-- 하게 수정
  • adminTeamUpdate confirm으로 수정시 agenda에서 CurrentTeam++ 하게 수정
  • adminTeamUpdate 에서 팀장 없는경우 404로 Exception처리
  • adminTeamUpdate 에서 Dto에 Status cancel일 경우 400으로 Exception처리
  • 각 코드에 맞게 테스트코드 수정 및 추가

💡Issue 번호

@AreSain AreSain added bug Something isn't working enhancement New feature or request labels Sep 6, 2024
@AreSain AreSain added this to the 7th Sprint 5 milestone Sep 6, 2024
@AreSain AreSain self-assigned this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.21%. Comparing base (c059f95) to head (534bf62).
Report is 149 commits behind head on dev.

Files with missing lines Patch % Lines
gg-data/src/main/java/gg/data/agenda/Agenda.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1005      +/-   ##
============================================
- Coverage     75.89%   74.21%   -1.69%     
- Complexity     1091     1221     +130     
============================================
  Files           366      393      +27     
  Lines          4800     5468     +668     
  Branches        391      439      +48     
============================================
+ Hits           3643     4058     +415     
- Misses          991     1219     +228     
- Partials        166      191      +25     
Flag Coverage Δ
integrationTest 69.12% <90.00%> (-0.88%) ⬇️
unitTest 35.71% <30.00%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AreSain AreSain merged commit 3898aee into dev Sep 6, 2024
5 checks passed
@AreSain AreSain deleted the 1004-bug-agendateamadmin에서-cancel-상태로-변경시에-confirm-팀일경우-currentteam이-줄어들지-않는-버그-발생 branch September 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
1 participant