Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Agenda 확정과 종료 분리 #905 #907

Merged
merged 20 commits into from
Jul 26, 2024

Conversation

yhames
Copy link
Contributor

@yhames yhames commented Jul 26, 2024

📌 개요

  • ✨ [Feature] Agenda 확정과 종료 분리

💻 작업사항

  • AgendaStatus 변경
    • 기존 CANCEL, ON_GOING, CONFIRM -> 변경 후 CANCEL, OPEN, CONFIRM, FINISH
  • Agenda 종료 및 시상 API
    • PATCH /agenda/fnish
  • Agenda 확정하기 API
    • PATCH /agenda/confirm
    • AgendaTeamStatus.OPEN인 팀에 대해서는 티켓 환불처리

✅ 변경로직

💡Issue 번호

@yhames yhames added enhancement New feature or request refactoring labels Jul 26, 2024
@yhames yhames added this to the 7th Sprint 4 milestone Jul 26, 2024
@yhames yhames self-assigned this Jul 26, 2024
@yhames yhames linked an issue Jul 26, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (c059f95) to head (66ccdf3).
Report is 97 commits behind head on dev.

Files Patch % Lines
...-data/src/main/java/gg/data/agenda/AgendaTeam.java 50.00% 1 Missing and 1 partial ⚠️
gg-data/src/main/java/gg/data/agenda/Agenda.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #907      +/-   ##
============================================
+ Coverage     75.89%   76.83%   +0.94%     
- Complexity     1091     1191     +100     
============================================
  Files           366      377      +11     
  Lines          4800     5151     +351     
  Branches        391      417      +26     
============================================
+ Hits           3643     3958     +315     
- Misses          991     1006      +15     
- Partials        166      187      +21     
Flag Coverage Δ
integrationTest 71.36% <86.95%> (+1.36%) ⬆️
unitTest 37.68% <65.21%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

Copy link
Contributor

@kimjieun0301 kimjieun0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@yhames yhames merged commit 4055124 into dev Jul 26, 2024
5 checks passed
@yhames yhames deleted the 905-feature-agenda-확정과-종료-분리 branch July 26, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Agenda 확정과 종료 분리
3 participants