Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Agenda 이미지 업로드 기능 추가 #929 #938

Merged
merged 43 commits into from
Aug 7, 2024

Conversation

yhames
Copy link
Contributor

@yhames yhames commented Aug 6, 2024

📌 개요

  • Agenda 이미지 업로드 기능 추가

💻 작업사항

  • POST /agenda/request
    • 대회 포스터 업로드 기능 추가
    • JSON -> form-data 변경 (@RequestBody -> @ModelAttribute)
  • POST /agenda/admin/request
    • 대회 포스터 수정 기능 추가
    • JSON -> form-data 변경 (@RequestBody -> @ModelAttribute)
  • ImageHandler 모듈 분리
    • Deprecated UserImageHandler, ItemImageHandler
    • Add ImageHandler Interface
    • Add AwsImageHandler for implementation of ImageHandler
    • Change AsyncNewUserImageUploader, AsyncNewItemImageUploader due to deprecation of UserImageHandler, ItemImageHandler

✅ 변경로직

💡Issue 번호

@yhames yhames added enhancement New feature or request refactoring labels Aug 6, 2024
@yhames yhames added this to the 7th Sprint 5 milestone Aug 6, 2024
@yhames yhames self-assigned this Aug 6, 2024
@yhames yhames linked an issue Aug 6, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 40 lines in your changes missing coverage. Please review.

Project coverage is 37.86%. Comparing base (c059f95) to head (d909c89).
Report is 115 commits behind head on dev.

Files Patch % Lines
...in/java/gg/utils/file/handler/AwsImageHandler.java 0.00% 38 Missing ⚠️
gg-data/src/main/java/gg/data/agenda/Agenda.java 33.33% 0 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (c059f95) and HEAD (d909c89). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c059f95) HEAD (d909c89)
integrationTest 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #938       +/-   ##
=============================================
- Coverage     75.89%   37.86%   -38.04%     
+ Complexity     1091      555      -536     
=============================================
  Files           366      376       +10     
  Lines          4800     5179      +379     
  Branches        391      419       +28     
=============================================
- Hits           3643     1961     -1682     
- Misses          991     3162     +2171     
+ Partials        166       56      -110     
Flag Coverage Δ
integrationTest ?
unitTest 37.86% <9.09%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhames yhames force-pushed the 929-feature-agenda-이미지-업로드-기능-추가 branch from 11f6fd9 to 5e8dd0a Compare August 7, 2024 04:05
kimjieun0301
kimjieun0301 previously approved these changes Aug 7, 2024
Copy link
Contributor

@kimjieun0301 kimjieun0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

AreSain
AreSain previously approved these changes Aug 7, 2024
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다.

@yhames yhames dismissed stale reviews from AreSain and kimjieun0301 via d909c89 August 7, 2024 05:18
@yhames yhames merged commit 0d39476 into dev Aug 7, 2024
4 of 5 checks passed
@yhames yhames deleted the 929-feature-agenda-이미지-업로드-기능-추가 branch August 7, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Agenda 이미지 업로드 기능 추가
3 participants