Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Agenda 취소하기 API 기능 구현 #939 #943

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

yhames
Copy link
Contributor

@yhames yhames commented Aug 8, 2024

📌 개요

  • Agenda 취소하기 API 기능 구현

💻 작업사항

  • Agenda 취소하기 API 기능 구현

✅ 변경로직

  • AgendaTeam
    • leaveTeam 관련 메서드 리팩토링
    • 팀 나가기 관련 OPEN status 확인하는 로직 controller로 변경
  • MaxUploadSizeExceededException GlobalHandler에 추가

💡Issue 번호

@yhames yhames added enhancement New feature or request refactoring labels Aug 8, 2024
@yhames yhames added this to the 7th Sprint 5 milestone Aug 8, 2024
@yhames yhames self-assigned this Aug 8, 2024
@yhames yhames linked an issue Aug 8, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.90%. Comparing base (c059f95) to head (ceef6a3).
Report is 116 commits behind head on dev.

Files Patch % Lines
...g/api/global/exception/GlobalExceptionHandler.java 0.00% 3 Missing ⚠️
...-data/src/main/java/gg/data/agenda/AgendaTeam.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #943      +/-   ##
============================================
+ Coverage     75.89%   76.90%   +1.01%     
- Complexity     1091     1199     +108     
============================================
  Files           366      376      +10     
  Lines          4800     5184     +384     
  Branches        391      418      +27     
============================================
+ Hits           3643     3987     +344     
- Misses          991     1010      +19     
- Partials        166      187      +21     
Flag Coverage Δ
integrationTest 71.37% <80.76%> (+1.37%) ⬆️
unitTest 37.92% <42.30%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kimjieun0301 kimjieun0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@yhames yhames merged commit 1f65e80 into dev Aug 9, 2024
5 checks passed
@yhames yhames deleted the 939-feature-agenda-취소하기-api-기능-구현 branch August 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Agenda 취소하기 API 기능 구현
3 participants