Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 [Refactoring] Agenda Admin 조회 Query Parameter 변경 #948 #949

Merged

Conversation

yhames
Copy link
Contributor

@yhames yhames commented Aug 12, 2024

📌 개요

  • 🔨 Admin API 조회 Query Parameter

💻 작업사항

  • Agenda 조회 API @ModeAttribute로 변경
  • AgendaTeam 조회 API @RequestParam로 변경
    • AgendaTeamKeyReqDto �삭제
  • AgendaAnnouncement 조회 API @ModeAttribute로 변경

✅ 변경로직

💡Issue 번호

@yhames yhames added enhancement New feature or request refactoring labels Aug 12, 2024
@yhames yhames added this to the 7th Sprint 5 milestone Aug 12, 2024
@yhames yhames self-assigned this Aug 12, 2024
@yhames yhames linked an issue Aug 12, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (c059f95) to head (73b66a7).
Report is 118 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #949      +/-   ##
============================================
+ Coverage     75.89%   77.08%   +1.18%     
- Complexity     1091     1205     +114     
============================================
  Files           366      376      +10     
  Lines          4800     5188     +388     
  Branches        391      418      +27     
============================================
+ Hits           3643     3999     +356     
- Misses          991     1008      +17     
- Partials        166      181      +15     
Flag Coverage Δ
integrationTest 71.54% <ø> (+1.54%) ⬆️
unitTest 37.89% <ø> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kimjieun0301 kimjieun0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페이지네이션 관련해서 바꾸셨군요,,제가 빨리 말씀드렸으면 한번 더 작업을 안하셨을텐데 반성합니다,,고생많으셨습니다!

@yhames yhames merged commit 2fd2968 into dev Aug 12, 2024
5 checks passed
@yhames yhames deleted the 948-refactoring-agenda-admin-조회-query-parameter-변경 branch August 12, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🔨 [Refactoring] Agenda Admin 조회 Query Parameter 변경
3 participants