🔨 [Refactoring] SlackService 공통 모듈 분리 #947

[yhames]

📌 개요

• 🔨 [Refactoring] SlackService 공통 모듈 분리

💻 작업사항

• agenda에서 Slackbot을 사용하기 위해 SlackService를 gg-utils로 옮겼습니다.
• MessageSender 인터페이스 및 AsyncSlackMessageSender 추가
  • 기존 Noti 에서 사용중이던 SlackService 추상화
  • NotiSlackMessageSender에서 AsyncSlackMessageSender 호출하는 방식으로 변경
• MailSender 인터페이스 및 AsyncMailSender 추가
  • 기존 Noti 에서 사용중이던 NotiMailSender 추상화
  • NotiMailSender에서 AsyncMailSender 호출하는 방식으로 변경

✅ 변경로직

💡Issue 번호

• closed 🔨 [Refactoring] SlackService 공통 모듈 분리 #947

[codecov]

Codecov Report

Attention: Patch coverage is 7.07965% with 105 lines in your changes missing coverage. Please review.

Project coverage is 36.05%. Comparing base (c059f95) to head (0fcfc06).
Report is 122 commits behind head on dev.

Files	Patch %	Lines
...main/java/gg/utils/sns/slack/SlackbotApiUtils.java	0.00%	40 Missing ⚠️
...va/gg/utils/sns/slack/AsyncSlackMessageSender.java	0.00%	19 Missing ⚠️
...pi/user/noti/service/sns/SlackPartybotService.java	0.00%	10 Missing ⚠️
...ong/api/user/noti/service/sns/SlackbotService.java	0.00%	10 Missing ⚠️
...c/main/java/gg/utils/sns/mail/AsyncMailSender.java	0.00%	7 Missing ⚠️
.../user/noti/service/sns/NotiSlackMessageSender.java	14.28%	6 Missing ⚠️
...ava/gg/utils/sns/slack/constant/SlackConstant.java	0.00%	5 Missing ⚠️
...ngpong/api/user/noti/service/PartyNotiService.java	0.00%	2 Missing ⚠️
...pingpong/api/user/noti/service/SnsNotiService.java	50.00%	2 Missing ⚠️
...main/java/gg/utils/sns/slack/response/Channel.java	0.00%	1 Missing ⚠️
... and 3 more

❗ There is a different number of reports uploaded between BASE (c059f95) and HEAD (0fcfc06). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (c059f95)	HEAD (0fcfc06)
integrationTest	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##                dev     #950       +/-   ##
=============================================
- Coverage     75.89%   36.05%   -39.85%     
+ Complexity     1091      555      -536     
=============================================
  Files           366      392       +26     
  Lines          4800     5414      +614     
  Branches        391      436       +45     
=============================================
- Hits           3643     1952     -1691     
- Misses          991     3406     +2415     
+ Partials        166       56      -110     

Flag	Coverage Δ
integrationTest	?
unitTest	36.05% <7.07%> (-0.80%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AreSain]

고생 많으셨습니다.

[kimjieun0301]

고생하셨습니다