Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”¨ [Refactoring] Agenda DateTimeFormat λ³€κ²½ #967 #968

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

yhames
Copy link
Contributor

@yhames yhames commented Aug 21, 2024

πŸ“Œ κ°œμš”

  • πŸ”¨ [Refactoring] Agenda DateTimeFormat λ³€κ²½

πŸ’» μž‘μ—…μ‚¬ν•­

  • DateTimeFormat λ³€κ²½
    • λ³€κ²½ μ „ : @DateTimeFormat(pattern = "yyyy-MM-dd'T'HH:mm:ss")
    • λ³€κ²½ ν›„ : @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME)
  • @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME)둜 λ³€κ²½ν•œ 이유
    • @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME)인 경우 @DateTimeFormat(pattern = "yyyy-MM-dd'T'HH:mm:ss")λ₯Ό ν¬ν•¨ν•˜μ—¬ 바인딩 κ°€λŠ₯
    • @DateTimeFormat(pattern = "yyyy-MM-dd'T'HH:mm:ss")인 경우 ν…ŒμŠ€νŠΈμ½”λ“œμ—μ„œ 좔가적인 λ¬Έμžμ—΄ 처리 ν•„μš”

βœ… λ³€κ²½λ‘œμ§

πŸ’‘Issue 번호

@yhames yhames added enhancement New feature or request refactoring labels Aug 21, 2024
@yhames yhames added this to the 7th Sprint 5 milestone Aug 21, 2024
@yhames yhames self-assigned this Aug 21, 2024
@yhames yhames linked an issue Aug 21, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 73.82%. Comparing base (c059f95) to head (d22bbcc).
Report is 130 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #968      +/-   ##
============================================
- Coverage     75.89%   73.82%   -2.07%     
- Complexity     1091     1206     +115     
============================================
  Files           366      392      +26     
  Lines          4800     5426     +626     
  Branches        391      436      +45     
============================================
+ Hits           3643     4006     +363     
- Misses          991     1229     +238     
- Partials        166      191      +25     
Flag Coverage Ξ”
integrationTest 68.66% <ΓΈ> (-1.34%) ⬇️
unitTest 35.97% <ΓΈ> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@kimjieun0301 kimjieun0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@yhames yhames merged commit d24516d into dev Aug 21, 2024
5 checks passed
@AreSain AreSain deleted the 967-refactoring-agenda-datetimeformat-λ³€κ²½ branch September 5, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

πŸ”¨ [Refactoring] Agenda DateTimeFormat λ³€κ²½
3 participants