Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Auth관련된 부분 Cookie삭제하는 로직 추가 #980 #981

Merged

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Aug 29, 2024

📌 개요

  • Auth 인증 실패시 로그인 다시할 수 있게 Cookie삭제하는 로직 추가
  • ErrorCode 전부 작성으로 인한 정리

💡Issue 번호

@AreSain AreSain added the enhancement New feature or request label Aug 29, 2024
@AreSain AreSain added this to the 7th Sprint 5 milestone Aug 29, 2024
@AreSain AreSain self-assigned this Aug 29, 2024
@AreSain AreSain linked an issue Aug 29, 2024 that may be closed by this pull request
Copy link
Contributor

@yhames yhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.12%. Comparing base (c059f95) to head (f90402a).
Report is 137 commits behind head on dev.

Files with missing lines Patch % Lines
...g-auth/src/main/java/gg/auth/FortyTwoAuthUtil.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #981      +/-   ##
============================================
- Coverage     75.89%   74.12%   -1.78%     
- Complexity     1091     1215     +124     
============================================
  Files           366      392      +26     
  Lines          4800     5449     +649     
  Branches        391      438      +47     
============================================
+ Hits           3643     4039     +396     
- Misses          991     1220     +229     
- Partials        166      190      +24     
Flag Coverage Δ
integrationTest 68.98% <95.12%> (-1.02%) ⬇️
unitTest 35.85% <95.12%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kimjieun0301 kimjieun0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@AreSain AreSain merged commit 9dc5196 into dev Aug 30, 2024
5 checks passed
@AreSain AreSain deleted the 980-feature-auth관련된-부분-cookie삭제하는-로직-추가 branch August 30, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Auth관련된 부분 Cookie삭제하는 로직 추가
3 participants