Conversation
Pull Request Test Coverage Report for Build 3337194975Details
💛 - Coveralls |
BREAKING CHANGE: Fastify is now a peer-dependency. BREAKING CHANGE: Removed deprecated options
Partially failed release 7.17.0 botched the lockfile.
By default, Sentry will use the `SENTRY_ENVIRONMENT` environement variable to configure its environment property. Since we required `NODE_ENV` to be always set, this was overriding this default behaviour. So now we only use `NODE_ENV` as a fallback if `SENTRY_ENVIRONMENT` is not set.
- Replace Yarn with PNPM - Add mkcert in CI/CD to generate test certificates - Add `https` option to enable TLS - Replace `delay` jig with built-in promisified `setTimeout`
Just in case someone tries to be smart and steal a CI-bound root CA..
Merging of envs may need to be done at the module top-level in consuming apps to be exposed to scripts like database migrations. Moreover, the server.env decoration can be overriden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #425.