Remove element access operators for integer-based vector interface #1372
+170
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knarfnitram
added
the
type: clean code
knarfnitram
added
the
taskforce: tpetra
mayrmt
reviewed
Oct 9, 2025
sebproell
reviewed
Oct 9, 2025
for integer-based linalg vector.
knarfnitram
force-pushed
the
reduce-element-access-operator-vector-int
branch
from
d4d1253 to
3114727
Compare
sebproell
reviewed
Oct 9, 2025
and replaces get_values with get_local_values.
knarfnitram
force-pushed
the
reduce-element-access-operator-vector-int
branch
from
3114727 to
f8af629
Compare
knarfnitram
commented
Oct 10, 2025
7 tasks
maxfirmbach
approved these changes
Oct 10, 2025
mayrmt
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Removes the element access operators from the class
class Vector<int>and substitutes it either byget_values()orlocal_values_as_span().Related Issues and Pull Requests
Related to #1121