Skip to content

Conversation

amgebauer
Copy link
Member

@amgebauer amgebauer commented Oct 10, 2025

Directly aggregate the compile time trace in the build job and clean all other time-trace json files to avoid running out of storage.

Closes #1361

Let's see whether this works: https://github.com/amgebauer/4C/actions/runs/18407082001/job/52449454062

@amgebauer amgebauer force-pushed the aggregate-compile-time-trace-after-build branch from feb412f to 84d643d Compare October 10, 2025 14:47
@amgebauer
Copy link
Member Author

At least the build job works again, but I have messed up the artifacts name. Next try: https://github.com/amgebauer/4C/actions/runs/18410019861/job/52459560774

@amgebauer amgebauer requested a review from Copilot October 10, 2025 14:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the compile time tracing workflow by aggregating ninja tracing output directly in the build job to prevent storage issues from individual trace files. The main goal is to consolidate tracing data earlier in the pipeline and clean up individual files to avoid running out of storage space.

Key changes:

  • Created a reusable action to aggregate ninja tracing output with optional cleanup
  • Moved trace aggregation from the analyze job to the build job
  • Simplified the analyze job by removing duplicate tracing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/nightly_tests.yml Integrated ninja tracing aggregation into build job and streamlined analyze job
.github/actions/aggregate_ninja_tracing/action.yml New reusable action for aggregating ninja traces with cleanup option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@amgebauer
Copy link
Member Author

Unfortunately, this does not (yet) work as hoped. ClangBuildAnalyzer does not find the aggregated json file as hoped. @sebproell For what reason do we need the ClangBuildAnalyzer? Is it just the txt-output?

We could maybe replace it with just generating the html-report.

@sebproell
Copy link
Member

ClangBuildAnalyzer aggregates the results and gives a very concise overview about the build performance. I use its "expensive header" info quite often.

@amgebauer amgebauer force-pushed the aggregate-compile-time-trace-after-build branch from 84d643d to 101bad2 Compare October 13, 2025 08:14
@amgebauer
Copy link
Member Author

I now moved the whole compile time analysis to the clang build job (in an extra action). Now, the clang18 job works again: https://github.com/amgebauer/4C/actions/runs/18459444810

In a later step, we can use the artifacts and generate an html report with catapult to make the report more usable.

Please review

@amgebauer amgebauer requested a review from Copilot October 13, 2025 10:45
@amgebauer amgebauer added the priority: high Issues with high priority label Oct 13, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@amgebauer amgebauer enabled auto-merge October 13, 2025 11:09
@amgebauer amgebauer merged commit 3ea25da into 4C-multiphysics:main Oct 13, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: high Issues with high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] clang18 build is failing due to running out of storage

3 participants