Draft: Delete unused input arguments in SparseMatrix #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
As pointed out in #137, the
assemble()
methods in 4C_linalg_sparsematrix.{hpp,cpp} had the input parameter eid. Although this parameter wasn't used inSparseMatrix
, it was found to be used to check if the given element has conditioned nodes in the strategies ofInterfaceSplitStrategy
in4C_ale_utils.hpp
and4C_fluid_utils.hpp
.As the assembly strategy in InterfaceSplitStrategy might have a performance gain, this is assessed in this draft. For now, I changed all the
InterfaceSplitStrategy
instances toCore::LinAlg::DefaultBlockMatrixStrategy
. If this works out, I think theInterfaceSplitStrategy
classes fromale
andfluid
libraries can be deleted.Related Issues and Merge Requests
Related to #137
Checklist