Skip to content

Conversation

@dharinib98
Copy link
Contributor

Description and Context

This PR adds a test checking the implementation of Lagrange Multipliers for beaminteraction problems (#637 ) with rotational coupling enabled.

Related Issues and Pull Requests

#1206

@dharinib98 dharinib98 self-assigned this Nov 14, 2025
@dharinib98 dharinib98 added the type: enhancement A new feature or enhancement to be implemented label Nov 14, 2025
@dharinib98 dharinib98 changed the title Add rotational coupling test with LM Add rotational coupling test for beam interaction with Lagrange Multipliers Nov 14, 2025
@dharinib98 dharinib98 changed the title Add rotational coupling test for beam interaction with Lagrange Multipliers Add rotational coupling test for beaminteraction with Lagrange Multipliers Nov 14, 2025
PREDICT: "TangDis"
LINEAR_SOLVER: 1
TOLDISP: 1e-12
TOLRES: 1e-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really have to get this convergence test to work properly very soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LINEAR_SOLVER: 1
TOLDISP: 1e-12
TOLRES: 1e-1
MAXITER: 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are 20 iterations needed? That seems like a lot to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this goes until the 19th iteration.

Copy link
Contributor

@maxfirmbach maxfirmbach Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, there might still be an issue 🤔. Going through 19 iterations really is a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A new feature or enhancement to be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants