Improve input of four conditions (spring dashpot, impendance, volumetric flow, traction correction) #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- VOLUMETRIC FLOW condition - TOTAL TRACTION CORRECTION condition
lauraengelhardt
added
team: fluid
team: input
team: structure
breaking change
sebproell
reviewed
Feb 26, 2025
amgebauer
reviewed
Feb 27, 2025
also to ensure an error is thrown for invalid values
Contributor
Author
|
Just for your information: @sebproell, @gilrrei, and I discussed how to tackle the current error during the metadata creation. We have come up with a solution, so this PR is on hold until this issue is resolved. |
Member
|
After #510, this PR can be reactivated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This PR improves the input for 4 conditions:
NORMALandCENTEROFMASSis set toself_evaluate, the user does not have to supply the corresponding vector anymore. This change is the reason for the breaking change label.Related Issues and Pull Requests
--