[Trilinos] Move from Isorropia to Zoltan2 #596
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfirmbach
added
status: in progress
maxfirmbach
requested review from
dharinib98,
eulovi,
isteinbrecher,
m-frey and
mayrmt
|
I took the liberty of collecting all failing tests: |
eulovi
reviewed
Apr 2, 2025
7 tasks
|
@mayrmt Would you mind taking a look at the tests related to |
|
@maxfirmbach I'll have a look. Not today, but hopefully tomorrow. |
|
@maxfirmbach FSI tests seem to just violate the result tolerance a little bit. Given the changes in subdomains combined with additive Schwarz components in the preconditioner, I am inclined to accept these changes as ok and just adapt the test result or the tolerance accordingly. Contact tests are a different story and need more investigation. |
|
I took care of the FSI and FS3I tests. I have removed them from the list of failing tests above. |
mayrmt
changed the title
|
Contact tests with rebalancing require a closer look, since they fail with a run time error in the graph partitioner. |
|
Ill look into the |
38 tasks
maxfirmbach
force-pushed
the
927-Move-from-isorropia-to-zoltan2
branch
from
1a483fd to
ce66a2b
Compare
|
@eulovi Seems like the implementation is correct from a conceptual point of view (even though the results of the partitioning differ). Would you mind working on the output related tests and fix them e.g. |
|
I fixed the following vtk output tests:
For the test If this is expected with the current changes, let me know to add the current VTK results. |
|
@eulovi Thanks for fixing some of the vtk related tests! Did you already remove the tests from the list above? Would you mind doing that? |
|
@isteinbrecher Any opinion on:
|
|
I think the changes in the test |
|
@isteinbrecher @eulovi The results in the "main" simulation pass, but there's a |
|
Is it possible to identify where this error occurs? |
|
@davidrudlstorfer Yeah, I messed up something ... |
|
I was able to restore the branch/commit via @maxfirmbach see https://github.com/davidrudlstorfer/4C/tree/927-Move-from-isorropia-to-zoltan2 |
|
@davidrudlstorfer @amgebauer Cool! Sorry again ... |
maxfirmbach
force-pushed
the
927-Move-from-isorropia-to-zoltan2
branch
from
2533c5d to
66ca65f
Compare
Signed-off-by: Max Firmbach <max.firmbach@unibw.de>
Tolerances can be loosened, since the solver tolerances are actually a couple of orders of magnitudes above the result tolerances.
Tolerances can be loosened, since the solver tolerances are actually a couple of orders of magnitudes above the result tolerances.
These tests target the contact preconditioner, thus their nonlinear solver tolerance is way to loose. Hence, results are affected by changes in the subdomain. Slightly loosening the result tolerances makes the test more robust. Number of linear iterations have changed as well.
Change in partioning has reduced the number of linear iterations.
maxfirmbach
force-pushed
the
927-Move-from-isorropia-to-zoltan2
branch
from
289b5b0 to
7f4f97e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This PR mainly consists of the first changes moving from
IsorropiatoZoltan2and for now mostly acts to view code changes and observe failing tests.Current problems:
It seems like the underlying hypergraph partitioning is somehow slightly different (Zoltan2: Hypergraph partitioning results differ compared to Isorropia trilinos/Trilinos#14010)Something related to periodic boundary conditions doesn't seem to work correctlyNested parallelism seems to make some issuesMicro/macro tests failRelated Issues and Pull Requests