Skip to content

Esc key clear search #7900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Esc key clear search #7900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deceafa
Add theme toggle to homepage
awarzu Oct 10, 2025
46c1586
Add ESC key to clear search bars
awarzu Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions newIDE/app/src/MainFrame/EditorContainers/HomePage/HomePageHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ import SaveProjectIcon from '../../SaveProjectIcon';
import Mobile from '../../../UI/CustomSvgIcons/Mobile';
import Desktop from '../../../UI/CustomSvgIcons/Desktop';
import HistoryIcon from '../../../UI/CustomSvgIcons/History';
import SunIcon from '../../../UI/CustomSvgIcons/Sun';
import Brightness3Icon from '@material-ui/icons/Brightness3';
import AuthenticatedUserContext from '../../../Profile/AuthenticatedUserContext';
import PreferencesContext from '../../Preferences/PreferencesContext';
const electron = optionalRequire('electron');

type Props = {|
Expand All @@ -40,6 +43,18 @@ export const HomePageHeader = ({
}: Props) => {
const { isMobile } = useResponsiveWindowSize();
const { profile } = React.useContext(AuthenticatedUserContext);
const preferences = React.useContext(PreferencesContext);
const isDarkTheme = preferences.values.themeName.includes('Dark');

const toggleTheme = React.useCallback(
() => {
const newTheme = isDarkTheme
? 'GDevelop default Light'
: 'GDevelop default Dark';
preferences.setThemeName(newTheme);
},
[isDarkTheme, preferences]
);

return (
<I18n>
Expand Down Expand Up @@ -96,6 +111,21 @@ export const HomePageHeader = ({
))}
<UserChip onOpenProfile={onOpenProfile} />
{profile && <NotificationChip />}
<IconButton
size="small"
id="homepage-theme-toggle-button"
onClick={toggleTheme}
tooltip={
isDarkTheme ? t`Switch to light mode` : t`Switch to dark mode`
}
color="default"
>
{isDarkTheme ? (
<SunIcon style={{ fontSize: 20 }} />
) : (
<Brightness3Icon style={{ fontSize: 20 }} />
)}
</IconButton>
{isMobile ? (
<IconButton size="small" onClick={onOpenLanguageDialog}>
<TranslateIcon fontSize="small" />
Expand Down
9 changes: 7 additions & 2 deletions newIDE/app/src/UI/SearchBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import Text from './Text';
import Autocomplete from '@material-ui/lab/Autocomplete';
import { type MessageDescriptor } from '../Utils/i18n/MessageDescriptor.flow';
import { useShouldAutofocusInput } from './Responsive/ScreenTypeMeasurer';
import { shouldValidate } from './KeyboardShortcuts/InteractionKeys';
import {
shouldValidate,
shouldCloseOrCancel,
} from './KeyboardShortcuts/InteractionKeys';
import TagChips from './TagChips';
import { I18n } from '@lingui/react';
import { useDebounce } from '../Utils/UseDebounce';
Expand Down Expand Up @@ -181,7 +184,9 @@ const SearchBar = React.forwardRef<Props, SearchBarInterface>(
};

const handleKeyPressed = (event: SyntheticKeyboardEvent<>) => {
if (shouldValidate(event)) {
if (shouldCloseOrCancel(event)) {
handleCancel();
} else if (shouldValidate(event)) {
onRequestSearch(value);
}
};
Expand Down