Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthogonal Range Searching #54

Merged
merged 14 commits into from
Mar 29, 2024
Merged

Orthogonal Range Searching #54

merged 14 commits into from
Mar 29, 2024

Conversation

kaitinghh
Copy link
Collaborator

@kaitinghh kaitinghh commented Oct 17, 2023

No description provided.

@4ndrelim
Copy link
Owner

tackling scary stuff..

Copy link
Owner

@4ndrelim 4ndrelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

1DORS reviewed.
Will review 2D ORS soon.

Copy link
Owner

@4ndrelim 4ndrelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor grammar edits / typo. Fix style changes and can merge.

* @param result A list to store the results of the traversal.
*/
public static void leftTraversal(RangeTreeNode<Integer> v, int low, List<Integer> result) {
if (v != null) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually yeah.. i've no idea why i said this back then lol..

i think i just wanted to remove this nesting by introducing
if v == null {
return
}
or smth

@kaitinghh kaitinghh merged commit f5bc79f into 4ndrelim:main Mar 29, 2024
1 check passed
@4ndrelim 4ndrelim linked an issue Apr 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orthogonal Range Searching
2 participants