-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orthogonal Range Searching #54
Conversation
tackling scary stuff.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
1DORS reviewed.
Will review 2D ORS soon.
src/main/java/algorithms/orthogonalRangeSearching/oneDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/README.md
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/README.md
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/oneDim/README.md
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/twoDim/README.md
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/twoDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/twoDim/OrthogonalRangeSearching.java
Show resolved
Hide resolved
src/main/java/algorithms/orthogonalRangeSearching/twoDim/OrthogonalRangeSearching.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, minor grammar edits / typo. Fix style changes and can merge.
* @param result A list to store the results of the traversal. | ||
*/ | ||
public static void leftTraversal(RangeTreeNode<Integer> v, int low, List<Integer> result) { | ||
if (v != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually yeah.. i've no idea why i said this back then lol..
i think i just wanted to remove this nesting by introducing
if v == null {
return
}
or smth
No description provided.