fix(deps): move pre-commit from core to dev dependencies #1624
+248
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Remove pre-commit>=4.2.0 from core dependencies - Add pre-commit>=4.2.0 to both [project.optional-dependencies].dev and [dependency-groups].dev - Prevents development tools from being installed in production environments - Resolves version conflicts caused by misplaced development dependencies Co-Authored-By: Jason Liu <jason@jxnl.co>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | 9caf2b5 | Commit Preview URL | Jun 20 2025, 06:54 PM |
github-actions
bot
added
dependencies
Co-Authored-By: Jason Liu <jason@jxnl.co>
- Fix Black formatting issues in 13 blog post markdown files - Add proper blank lines after imports and improve code spacing - Resolves failing CI check for documentation linting - Changes applied automatically by pytest-examples Co-Authored-By: Jason Liu <jason@jxnl.co>
…of-density.md - Fix unclosed triple-quote string in anthropic.md causing parsing error - Add missing spaces after comments in chain-of-density.md code blocks - Add proper blank lines between code sections - Fix ruff linting issues: unused parameters and unnecessary file open modes - Resolves remaining CI failure in documentation linting Co-Authored-By: Jason Liu <jason@jxnl.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Version Conflicts: Move pre-commit to Development Dependencies
Description
This PR resolves version conflicts in the instructor project by moving
pre-commit>=4.2.0from core dependencies to development dependencies where it belongs.Problem
The
pre-commit>=4.2.0package was incorrectly listed as a core dependency inpyproject.toml, which meant that development tools were being installed in production environments. This can cause version conflicts and unnecessary bloat in production deployments.Solution
pre-commit>=4.2.0from the coredependencieslistpre-commit>=4.2.0to both:[project.optional-dependencies].dev[dependency-groups].devThis ensures consistency between both dependency specification methods used in the project while properly categorizing pre-commit as a development-only dependency.
Changes
pyproject.toml:"pre-commit>=4.2.0"from core dependencies (line 17)"pre-commit>=4.2.0"to[project.optional-dependencies].dev"pre-commit>=4.2.0"to[dependency-groups].devTesting
uv syncuv sync --group devpython -c "import instructor"uv run ruff check .Impact
Link to Devin run: https://app.devin.ai/sessions/c236f82acdb4459a8691ed87207f9662
Requested by: Jason Liu (work@jxnl.co)