Fix brittle test mocks at minimum token threshold #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on flagged modules
Fix brittle test mocks at minimum token threshold
Jan 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses test brittleness by updating mock responses in the orchestrate_content tests that were using text with exactly 5 tokens (the minimum threshold). By increasing these to 14-15 tokens with more comprehensive text, the tests become more resilient to potential changes in the DEFAULT_MIN_TOKENS configuration value.
Changes:
- Updated two test mock responses to use comprehensive text with sufficient tokens (14-15 tokens vs. the previous ~5 tokens)
- Both updates follow the established pattern from line 36 of the same test file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_MIN_TOKENSwould break themChanges
tests/test_orchestrate_content.py:93: Mock response increased from 5 to 15 tokenstests/test_orchestrate_content.py:176: Mock response increased from 5 to 14 tokensBoth mocks now use comprehensive text matching the pattern established in line 36 of the same file.
Testing
test_orchestrate_content.pypassChecklist
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.